Close stdin after writing to prevent LFS smudge hang#123
Merged
Conversation
flowStartProcess wrote to the child's stdin but never closed the write channel. DownloadLfsObjects pipes an LFS pointer into 'git lfs smudge', which reads stdin until EOF; without closeWriteChannel() the process blocks forever and the task never finishes, leaving the UI busy. Close the write channel after writing stdin.
Owner
|
My understanding is I think your fix can still prevent In this case, fortunately our UI stays responsive and allows killing the underlying process if it takes too long. But having |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
RepoTask.flowStartProcesswrites to the child process's stdin but never closes the write channel:DownloadLfsObjectspipes an LFS pointer intogit lfs smudge, which reads stdin until EOF. With the write channel left open,smudgeblocks forever waiting for EOF, the task never finishes, and the UI stays busy.Repro
Open a diff of an LFS-tracked file whose object isn't cached locally → the smudge task hangs indefinitely.
Fix
Call
process.closeWriteChannel()after writing stdin, so children that read to EOF terminate normally.Prepared with Claude Fable 5 (Low effort mode).